Repository navigation
Feature A: Preserve Reader sample freshness across landing journal writes (#307) - #1373
Merged
Merged
Conversation
This was referenced Nov 18, 2026
Collaborator
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature A · T2 · #307 merge-flow row (comment 6958648117), prerequisite for the landing journal #1345.
A journal publication row carries a Board for replay. The Lead Reader skips those rows within its existing 1 MiB tail bound and uses the latest genuine Reader observation, including its original timestamp and App quota. A fresh Reader row without quota takes precedence. Missing or out-of-range Reader evidence fails closed.
This is the exact landing-only Reader and fixture from Integ's #1345 reconciliation. The single-file diff is 80 additions and 7 deletions. It adds no writer or runtime activation. Integ handoff
The fixture-only head 3022dbd failed only the expected Reader timestamp regression on both architectures. Exact repair 781ec21 passed all 1,424 tests with zero skips on x86_64 and ARM64. Rustfmt and diff checks passed. Before run · Repair run